Data extensions editor: Allow users to pick an existing database from their workspace#2643
Merged
shati-patel merged 3 commits intomainfrom Jul 27, 2023
Merged
Data extensions editor: Allow users to pick an existing database from their workspace#2643shati-patel merged 3 commits intomainfrom
shati-patel merged 3 commits intomainfrom
Conversation
Since users can now use an existing DB from their workspace, we don't need to worry about cluttering up the workspace with downloaded DBs.
robertbrignull
approved these changes
Jul 26, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
🎉
Code LGTM and works locally when tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Model from source" and "Model dependency" buttons currently automatically prompt you to download a database, even if you already have a relevant DB in your workspace. This PR changes that behaviour, so that users can choose a local one if they want to:
Checklist
N/A: Internal only 🦀
ready-for-doc-reviewlabel there.