Skip to content

Make query resolver more generic#2634

Merged
koesie10 merged 2 commits intomainfrom
koesie10/cleanup-query-resolver
Jul 26, 2023
Merged

Make query resolver more generic#2634
koesie10 merged 2 commits intomainfrom
koesie10/cleanup-query-resolver

Conversation

@koesie10
Copy link
Copy Markdown
Member

This will make the query resolving functionality currently used for contextual queries more generic and usable for resolving other types of queries as well (e.g. based on tags instead of on id). This is in preparation for #2633. There should be no changes in behavior, except for a single changed error message (which adds kind "definitions", to the error message, so shouldn't really have any influence).

It's easiest to review this commit-by-commit.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review July 25, 2023 09:53
@koesie10 koesie10 requested review from a team as code owners July 25, 2023 09:53
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As far as I can tell this is just extracting functions to new files without changing them significantly. And I appreciate that you added more tests.

@koesie10 koesie10 merged commit 83cc983 into main Jul 26, 2023
@koesie10 koesie10 deleted the koesie10/cleanup-query-resolver branch July 26, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants