Update release test plan#2616
Merged
shati-patel merged 1 commit intomainfrom Jul 17, 2023
Merged
Conversation
Just a couple of minor things I noticed during the latest release
shati-patel
commented
Jul 17, 2023
| #### Test case 2: Running a problem query and viewing results | ||
|
|
||
| 1. Open the [javascript UnsafeJQueryPlugin query](https://github.com/github/codeql/blob/main/javascript/ql/src/Security/CWE-079/UnsafeJQueryPlugin.ql). | ||
| 1. Open the [javascript ReDoS query](https://github.com/github/codeql/blob/main/javascript/ql/src/Performance/ReDoS.ql). |
Contributor
Author
There was a problem hiding this comment.
This was probably a copy-paste error from the section above. UnsafeJQueryPlugin.ql isn't a normal problem query, and doesn't have results on babel/babel 🙈
shati-patel
commented
Jul 17, 2023
| 4. Once the query completes: | ||
| - Check that the results table is rendered | ||
| - Check that alert locations can be clicked on | ||
| - Check that result locations can be clicked on |
Contributor
Author
There was a problem hiding this comment.
Minor: Technically not "alerts" when the query is a non-problem query, but just raw results.
aeisenberg
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of minor things I noticed during the latest release!
Checklist
ready-for-doc-reviewlabel there.