Skip to content

Update assert-pure.ql now that the /pure directory has been removed#2533

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/assert-pure
Jun 22, 2023
Merged

Update assert-pure.ql now that the /pure directory has been removed#2533
robertbrignull merged 1 commit intomainfrom
robertbrignull/assert-pure

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

(Should be merged once all PRs for moving files out of the /pure directory have been merged)

Once the /pure directory has been removed by moving files elsewhere, we should also update update-pure.ql. It now only needs to check for files in /common, and we should rename it to not mention the word "pure" anywhere if at all possible.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team June 21, 2023 11:35
@robertbrignull robertbrignull requested a review from a team as a code owner June 21, 2023 11:35
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@robertbrignull robertbrignull merged commit 480bd48 into main Jun 22, 2023
@robertbrignull robertbrignull deleted the robertbrignull/assert-pure branch June 22, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants