Skip to content

Make assert-pure.ql ignore all /vscode/ directories#2458

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/common-vscode
May 31, 2023
Merged

Make assert-pure.ql ignore all /vscode/ directories#2458
robertbrignull merged 1 commit intomainfrom
robertbrignull/common-vscode

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

In #2455 I made assert-pure.ql cover all of /src/common except for /src/common/vscode but I didn't realise we also have directories like /src/common/logging/vscode. So in this PR I change the query to ignore all directories containing /vscode/ anywhere in their path, and not just /src/common/vscode.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team May 31, 2023 10:04
@robertbrignull robertbrignull requested a review from a team as a code owner May 31, 2023 10:04
@robertbrignull
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@robertbrignull robertbrignull enabled auto-merge May 31, 2023 10:13
@robertbrignull robertbrignull merged commit 00bd7b7 into main May 31, 2023
@robertbrignull robertbrignull deleted the robertbrignull/common-vscode branch May 31, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants