Add support for quick eval count to the query runner#2417
Merged
Conversation
This only adds support internally to the query runner, without any UI support.
396e1aa to
0c83319
Compare
0c83319 to
537bb29
Compare
aeisenberg
approved these changes
May 26, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
I don't fully understand the context of this change, but it looks generally safe and fine.
Comment on lines
+74
to
+76
| * This is only supported by the new query server | ||
| * but it isn't worth having a separate type and | ||
| * it is fine to have an ignored optional field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only adds support internally to the query runner, without any UI support. I will add basic support (command palette only) in a separate PR.
I'm not completely happy about the api as we switch between an enum and booleans. The issue is that before running for quick eval we simply have a boolean and afterwards we have an optional position. It should then really become a optional (position and count enabled) but in a bunch of places we need backwards compatibility as we persist it as json. So we end up with an invalid state (no quick eval position, but quickEvalCountOnly is set), and a difference between the initial enum and the later boolean state. However I couldn't think of much better as I don't want to add yet more boolean arguments to the initial query.
Checklist
ready-for-doc-reviewlabel there.