Skip to content

Fix error when model file does not exist#2337

Merged
koesie10 merged 1 commit intomainfrom
koesie10/fix-not-exists-error
Apr 18, 2023
Merged

Fix error when model file does not exist#2337
koesie10 merged 1 commit intomainfrom
koesie10/fix-not-exists-error

Conversation

@koesie10
Copy link
Copy Markdown
Member

When you have just created a model file using the quick picker/input box, the data extension editor will try to read it and fail with an error message. This adds a check to ensure the model file exists and if it doesn't, it will not try to read in the file.

This should always be safe since the model file picker will only allow you to select existing files.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

When you have just created a model file using the quick picker/input
box, the data extension editor will try to read it and fail with an
error message. This adds a check to ensure the model file exists and if
it doesn't, it will not try to read in the file.

This should always be safe since the model file picker will only allow
you to select existing files.
@koesie10 koesie10 requested a review from starcke April 17, 2023 13:41
@koesie10 koesie10 requested a review from a team as a code owner April 17, 2023 13:42
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koesie10 koesie10 enabled auto-merge April 18, 2023 07:25
@koesie10 koesie10 merged commit 94aee8a into main Apr 18, 2023
@koesie10 koesie10 deleted the koesie10/fix-not-exists-error branch April 18, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants