Skip to content

Small fixes to skeleton query wizard#2305

Merged
elenatanasoiu merged 7 commits intomainfrom
elena/yer-a-progress-query
Apr 13, 2023
Merged

Small fixes to skeleton query wizard#2305
elenatanasoiu merged 7 commits intomainfrom
elena/yer-a-progress-query

Conversation

@elenatanasoiu
Copy link
Copy Markdown
Contributor

@elenatanasoiu elenatanasoiu commented Apr 12, 2023 •
edited
Loading

Came out of final set of reviews for #2250 (comment)

  • Fixes progress indicator to provide the correct max steps
  • Fixes regex expression
  • Moves up place where we catch errors if we fail to open an example file
  • Renames codeQL.createSkeletonQuery to codeQL.createQuery
  • Import individual methods instead of whole databaseFetcher object
  • Corrects some error messages
  • Temporarily adds codeQL.createQuery command behind a canary flag

@elenatanasoiu elenatanasoiu requested a review from a team as a code owner April 12, 2023 15:38
@elenatanasoiu elenatanasoiu mentioned this pull request Apr 12, 2023
Merged
@elenatanasoiu elenatanasoiu requested a review from a team April 12, 2023 15:47
@elenatanasoiu elenatanasoiu changed the title Small fixes to skeleton query Small fixes to skeleton query wizard Apr 12, 2023
shati-patel
shati-patel reviewed Apr 12, 2023
View reviewed changes
Comment thread extensions/ql-vscode/package.json Outdated
Comment thread extensions/ql-vscode/src/skeleton-query-wizard.ts Outdated
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-windows-query branch from 58c808f to e298f2b Compare April 12, 2023 16:39
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-progress-query branch from 56de328 to 820dd98 Compare April 12, 2023 16:44
shati-patel
shati-patel approved these changes Apr 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎈

@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-progress-query branch from 820dd98 to 3627139 Compare April 12, 2023 16:52
@elenatanasoiu
Copy link
Copy Markdown
Contributor Author

elenatanasoiu commented Apr 12, 2023

Thanks @shati-patel !

Have rebased to remove conflicts. Will come back to this tomorrow when I'm sure the CI gods will be merciful.

Base automatically changed from elena/yer-a-windows-query to main April 13, 2023 07:54
@elenatanasoiu elenatanasoiu merged commit 8c0d0d8 into main Apr 13, 2023
@elenatanasoiu elenatanasoiu deleted the elena/yer-a-progress-query branch April 13, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elenatanasoiu @shati-patel