Skip to content

Add empty data extension editor view#2262

Merged
koesie10 merged 1 commit intomainfrom
koesie10/data-extension-editor-setup
Apr 4, 2023
Merged

Add empty data extension editor view#2262
koesie10 merged 1 commit intomainfrom
koesie10/data-extension-editor-setup

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Apr 4, 2023

This adds an empty data extension editor view which is only available behind the codeQL.dataExtensions.editor and codeQL.canary settings.

This is a split-up from #2257.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 added the secexp label Apr 4, 2023
@koesie10 koesie10 requested a review from a team April 4, 2023 10:09
@koesie10 koesie10 requested a review from a team as a code owner April 4, 2023 10:09
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 4, 2023
View reviewed changes
Comment thread extensions/ql-vscode/package.json Fixed
@koesie10
Add empty data extension editor view
478c095 
This adds an empty data extension editor view which is only available
behind the `codeQL.dataExtensions.editor` and `codeQL.canary` settings.
@koesie10 koesie10 force-pushed the koesie10/data-extension-editor-setup branch from 14c9e3c to 478c095 Compare April 4, 2023 10:14
charisk
charisk approved these changes Apr 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one question: do we also want to have a feature flag just for the view so that commands aren't available to all canary users? That would give us more control about when we unveil the feature.

@koesie10
Copy link
Copy Markdown
Member Author

koesie10 commented Apr 4, 2023

LGTM! Only one question: do we also want to have a feature flag just for the view so that commands aren't available to all canary users? That would give us more control about when we unveil the feature.

Sorry, the description is somewhat ambiguous but it's only available when the user has set codeQL.canary and codeQL.dataExtensions.editor, so codeQL.dataExtensions.editor always needs to be set.

@charisk
Copy link
Copy Markdown
Contributor

charisk commented Apr 4, 2023

LGTM! Only one question: do we also want to have a feature flag just for the view so that commands aren't available to all canary users? That would give us more control about when we unveil the feature.

Sorry, the description is somewhat ambiguous but it's only available when the user has set codeQL.canary and codeQL.dataExtensions.editor, so codeQL.dataExtensions.editor always needs to be set.

Oh yeah, not sure how I missed that from the code 😓 Looks good!

@koesie10 koesie10 enabled auto-merge April 4, 2023 10:45
@koesie10 koesie10 merged commit 60e3963 into main Apr 4, 2023
@koesie10 koesie10 deleted the koesie10/data-extension-editor-setup branch April 4, 2023 10:52
@koesie10 koesie10 mentioned this pull request Apr 4, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koesie10 @charisk @github-advanced-security