Move LocalQueries commands to be member functions#2245
Conversation
|
Just wanting to be clear. |
| const astBuilder = createAstBuilder(); | ||
| const roots = await astBuilder.getRoots(); | ||
|
|
||
| const bqrsPath = path.normalize("/a/b/c/results.bqrs"); |
There was a problem hiding this comment.
Any understanding of why this test had to be changed?
There was a problem hiding this comment.
I think that change went into the base PR, but the reason for the change was that previously, the test code passed in "/a/b/c" as the path to the BQRS file itself, which got passed through the implementation verbatim and came out the other end with forward slashes intact. With my changes, "/a/b/c" is treated as the query output directory, which goes through some path calls (join, etc.) before the BQRS path comes out the other end with platform-specific separators.
Oh, yikes! That's the wrong target branch. |
9b636ec to
aef836f
Compare
This PR implements a review suggestion from #2244. I've made it a separate, dependent PR to avoid making the original PR's diffs even worse.