Skip to content

Turn off support for local dbs and remote root 'remote' node from new db panel#1990

Merged
charisk merged 2 commits intomainfrom
charisk/disable-local-dbs
Jan 20, 2023
Merged

Turn off support for local dbs and remote root 'remote' node from new db panel#1990
charisk merged 2 commits intomainfrom
charisk/disable-local-dbs

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 20, 2023

Since support for local dbs is only partially implemented in the new panel, we've decided to turn it off for now. In this PR we:

As part of this it means that we have to mark a few tests as skipped.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 20, 2023
@charisk charisk requested review from a team as code owners January 20, 2023 10:00
norascheuch
norascheuch approved these changes Jan 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@charisk charisk merged commit d7fae74 into main Jan 20, 2023
@charisk charisk deleted the charisk/disable-local-dbs branch January 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @norascheuch