Add exporting of in-progress/cancelled results#1816
Merged
Conversation
This will allow exporting results for a variant analysis which is cancelled or in-progress. Repositories for which the results are not yet available or which have not yet been downloaded will not be exported. The header of the summary file is incorrect, but this will be fixed in a follow-up PR.
This will disable the export and copy buttons when no results would be exported by executing the command. In contrast to the "normal" filtering in the view, this will also take into account the checkboxes since those are also used in the extension host.
robertbrignull
approved these changes
Dec 2, 2022
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
Code LGTM and I've tried it out on an in-progress query and a cancelled query and it's working well for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow exporting results for a variant analysis which is cancelled or in-progress. Repositories for which the results are not yet available or which have not yet been downloaded will not be exported. This will also conditionally disable the buttons, based on whether any results would be exported (based on the filters). Please review this commit-by-commit.
The header of the summary file is incorrect, but this will be fixed in a follow-up PR.
Checklist
ready-for-doc-reviewlabel there.