Move logging code to /common/logging and split into multiple files#1800
Merged
Move logging code to /common/logging and split into multiple files#1800
Conversation
koesie10
approved these changes
Nov 25, 2022
Member
koesie10
left a comment
There was a problem hiding this comment.
LGTM too, but there is a file extensions/ql-vscode/.DS_Store which probably shouldn't be there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging code was all in one
loggingmodule. This PR splits that code into multiple files and moves them to the right place in/common. We intentionally split VS Code specific and VS Code agnostic code to help with testing.This was a cut/paste/fix imports change. In a separate PR I'll update the docs and names a bit.
Checklist
N/A:
ready-for-doc-reviewlabel there.