Conversation
This converts all pure tests to Jest. This was done by first running `npx jest-codemods` with the Mocha transformation, then manually fixing any places where it hadn't automatically converted the correct thing or had missed things (mostly Sinon). This also sets up VSCode correctly for running Jest.
The config store was not being disposed in tests, resulting in Chokidar watchers being left open. This was causing tests to not exit since there were still open file descriptors. This commit also fixes the `DbConfigStore` to make the correct `super` call in its `dispose` method.
charisk
approved these changes
Nov 22, 2022
When `jest-codemods` was run, it replaced the error message `array.join` by a comment for the error message. Since Jest does not support custom error messages out-of-the-box, this will instead do an equality check with an empty array, which will ensure that the received array is printed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts all pure tests to Jest. This was done by first running
npx jest-codemodswith the Mocha transformation, then manually fixing any places where it hadn't automatically converted the correct thing or had missed things (mostly Sinon).This also sets up VSCode correctly for running Jest.
Checklist
ready-for-doc-reviewlabel there.