Change remote queries to test against submitted data#1746
Merged
Conversation
The remote queries tests were testing the data on the filesystem, rather than the data submitted to the server. This required using a `dryRun` parameter to prevent deleting the temporary directory, while we can actually just test against the submitted data. This will create an in-memory filesystem of the submitted query pack by un-tar-gz'ing the query pack into memory and using that to test the existence of certain files.
3 tasks
charisk
approved these changes
Nov 11, 2022
Contributor
charisk
left a comment
There was a problem hiding this comment.
Looking good, thanks for improving tests!
Base automatically changed from
koesie10/extract-remote-query-preparation
to
main
November 11, 2022 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote queries tests were testing the data on the filesystem, rather than the data submitted to the server. This required using a
dryRunparameter to prevent deleting the temporary directory, while we can actually just test against the submitted data.This will create an in-memory filesystem of the submitted query pack by un-tar-gz'ing the query pack into memory and using that to test the existence of certain files.
Checklist
ready-for-doc-reviewlabel there.