Skip to content

Handle canceled status in variant analysis view#1727

Merged
koesie10 merged 1 commit intomainfrom
koesie10/canceled-view
Nov 8, 2022
Merged

Handle canceled status in variant analysis view#1727
koesie10 merged 1 commit intomainfrom
koesie10/canceled-view

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 8, 2022

The variant analysis view was missing an alert when the variant analysis was canceled. This adds it, and also adds a story for checking what the view of a canceled variant analysis looks like.

Screenshot 2022-11-08 at 13 43 08

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

The variant analysis view was missing an alert when the variant
analysis was canceled. This adds it, and also adds a story for checking
what the view of a canceled variant analysis looks like.
@koesie10 koesie10 added the secexp label Nov 8, 2022
@koesie10 koesie10 requested a review from a team as a code owner November 8, 2022 12:12
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the story!

@koesie10 koesie10 merged commit a24e7c6 into main Nov 8, 2022
@koesie10 koesie10 deleted the koesie10/canceled-view branch November 8, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants