Make hasInterpretedResults not be async#1703
Closed
robertbrignull wants to merge 1 commit intomainfrom
Closed
Conversation
elenatanasoiu
approved these changes
Nov 3, 2022
Contributor
Author
|
Thanks for the review but I've changed my mind about whether changing async to sync is actually an improvement. I now don't think it's worth it. It either makes no difference or it removes flexibility. Also if we do ever want to do this change in the future it's very easy, so I don't think it's worth merging this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny improvement I thought of when doing #1697 but didn't / forgot to include in that PR.
This is something I did when trying to pull out the
getContextValuemethod and mock things, which didn't turn out well (see comment on that PR) but this small bit could be nice and could make things easier to mock and test in the future.Checklist
ready-for-doc-reviewlabel there.