Skip to content

Make hasInterpretedResults not be async#1703

Closed
robertbrignull wants to merge 1 commit intomainfrom
robertbrignull/sync_hasInterpretedResults
Closed

Make hasInterpretedResults not be async#1703
robertbrignull wants to merge 1 commit intomainfrom
robertbrignull/sync_hasInterpretedResults

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

A tiny improvement I thought of when doing #1697 but didn't / forgot to include in that PR.

This is something I did when trying to pull out the getContextValue method and mock things, which didn't turn out well (see comment on that PR) but this small bit could be nice and could make things easier to mock and test in the future.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team November 2, 2022 16:10
@robertbrignull robertbrignull requested a review from a team as a code owner November 2, 2022 16:10
@robertbrignull
Copy link
Copy Markdown
Contributor Author

Thanks for the review but I've changed my mind about whether changing async to sync is actually an improvement. I now don't think it's worth it. It either makes no difference or it removes flexibility. Also if we do ever want to do this change in the future it's very easy, so I don't think it's worth merging this now.

@robertbrignull robertbrignull deleted the robertbrignull/sync_hasInterpretedResults branch November 3, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants