Merged
Conversation
koesie10
approved these changes
Oct 19, 2022
| */ | ||
| export class MockGitHubApiServer { | ||
| private isListening: boolean; | ||
| private config: MockGitHubApiConfigListener; |
Member
There was a problem hiding this comment.
Can this be readonly and instantiated inline?
Suggested change
| private config: MockGitHubApiConfigListener; | |
| private readonly config = new MockGitHubApiConfigListener(); |
I'm also happy to leave it like this.
Contributor
Author
There was a problem hiding this comment.
I'm not a huge fan of adding logic outside of the constructor (but that runs as part of the constructor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up a config listener to start and stop the mock server.
Checklist
N/A - internal only:
ready-for-doc-reviewlabel there.