Remove cast now unzipper typedef fix is merged#162
Merged
alexet merged 1 commit intogithub:masterfrom Nov 15, 2019
henrymercer:remove-cast-after-fixed-typedef
Merged
Remove cast now unzipper typedef fix is merged#162alexet merged 1 commit intogithub:masterfrom henrymercer:remove-cast-after-fixed-typedef
alexet merged 1 commit intogithub:masterfrom
henrymercer:remove-cast-after-fixed-typedef
Conversation
Related PR fixing typedef: DefinitelyTyped/DefinitelyTyped#40240
alexet
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a cast was necessary as the type for
unzipper.Open.file.extractwas incorrect. My PR to fix the typedef (DefinitelyTyped/DefinitelyTyped#40240) has now been merged, so this PR removes the cast.