Revert "Upgrade from vscode-test to @vscode/test-electron"#1612
Merged
aeisenberg merged 1 commit intomainfrom Oct 14, 2022
Merged
Revert "Upgrade from vscode-test to @vscode/test-electron"#1612aeisenberg merged 1 commit intomainfrom
aeisenberg merged 1 commit intomainfrom
Conversation
angelapwen
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1586
If you look at every windows CLI test run after this change goes in, you can see that the CLI tests first fail with exit code 7, then an automatic retry kicks in. It then fails with exit code 1, and retries. Finally, there is an exit code 0, but only because the tests don't actually run.
Example is here: https://github.com/github/vscode-codeql/actions/runs/3251885347/jobs/5338773016#step:9:292