Conversation
When the `viewLoaded` message is received by the view, it will now retrieve the variant analysis from the manager and send it to the view. This will allow the view to display the variant analysis.
The `VariantAnalysis` component will now only receive values from the `VariantAnalysisView`. We still allow setting defaults to support Storybook.
The mock variant analysis view would only show the loading message. This completely removes it since it does not provide value anymore.
…ssage' into koesie10/view-loaded-message
Base automatically changed from
koesie10/request-repo-results-message
to
main
October 11, 2022 14:48
charisk
reviewed
Oct 12, 2022
Contributor
charisk
left a comment
There was a problem hiding this comment.
Looking really good, just a couple of comments.
|
|
||
| const variantAnalysis = await this.manager.getVariantAnalysis(this.variantAnalysisId); | ||
|
|
||
| if (!variantAnalysis) { |
Contributor
There was a problem hiding this comment.
Should we show a notification to the user to tell them something went wrong?
Member
Author
There was a problem hiding this comment.
I think that would indeed be useful, I'll add a showAndLogWarningMessage call here.
charisk
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will handle the
viewLoadedmessage by sending the variant analysis to the webview. It will also clean up some things that are not relevant anymore after this change.It's probably easiest to review this PR commit-by-commit.
Checklist
ready-for-doc-reviewlabel there.