Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/abstract-webview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { DisposableObject } from './pure/disposable-object';
import { tmpDir } from './helpers';
import { getHtmlForWebview, WebviewMessage, WebviewView } from './interface-utils';

export type InterfacePanelConfig = {
export type WebviewPanelConfig = {
viewId: string;
title: string;
viewColumn: ViewColumn;
Expand Down Expand Up @@ -90,7 +90,7 @@ export abstract class AbstractWebview<ToMessage extends WebviewMessage, FromMess
return this.panel;
}

protected abstract getPanelConfig(): InterfacePanelConfig;
protected abstract getPanelConfig(): WebviewPanelConfig;

protected abstract onPanelDispose(): void;

Expand Down
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/compare/compare-view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import resultsDiff from './resultsDiff';
import { CompletedLocalQueryInfo } from '../query-results';
import { getErrorMessage } from '../pure/helpers-pure';
import { HistoryItemLabelProvider } from '../history-item-label-provider';
import { AbstractWebview, InterfacePanelConfig } from '../abstract-webview';
import { AbstractWebview, WebviewPanelConfig } from '../abstract-webview';

interface ComparePair {
from: CompletedLocalQueryInfo;
Expand Down Expand Up @@ -95,7 +95,7 @@ export class CompareView extends AbstractWebview<ToCompareViewMessage, FromCompa
}
}

protected getPanelConfig(): InterfacePanelConfig {
protected getPanelConfig(): WebviewPanelConfig {
return {
viewId: 'compareView',
title: 'Compare CodeQL Query Results',
Expand Down
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import {
} from './interface-utils';
import { getDefaultResultSetName, ParsedResultSets } from './pure/interface-types';
import { RawResultSet, transformBqrsResultSet, ResultSetSchema } from './pure/bqrs-cli-types';
import { AbstractWebview, InterfacePanelConfig } from './abstract-webview';
import { AbstractWebview, WebviewPanelConfig } from './abstract-webview';
import { PAGE_SIZE } from './config';
import { CompletedLocalQueryInfo } from './query-results';
import { HistoryItemLabelProvider } from './history-item-label-provider';
Expand Down Expand Up @@ -174,7 +174,7 @@ export class ResultsView extends AbstractWebview<IntoResultsViewMsg, FromResults
await this.postMessage({ t: 'navigatePath', direction });
}

protected getPanelConfig(): InterfacePanelConfig {
protected getPanelConfig(): WebviewPanelConfig {
return {
viewId: 'resultsView',
title: 'CodeQL Query Results',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { SHOW_QUERY_TEXT_MSG } from '../query-history';
import { AnalysesResultsManager } from './analyses-results-manager';
import { AnalysisResults } from './shared/analysis-result';
import { humanizeUnit } from '../pure/time';
import { AbstractWebview, InterfacePanelConfig } from '../abstract-webview';
import { AbstractWebview, WebviewPanelConfig } from '../abstract-webview';

export class RemoteQueriesView extends AbstractWebview<ToRemoteQueriesMessage, FromRemoteQueriesMessage> {
private currentQueryId: string | undefined;
Expand Down Expand Up @@ -100,7 +100,7 @@ export class RemoteQueriesView extends AbstractWebview<ToRemoteQueriesMessage, F
};
}

protected getPanelConfig(): InterfacePanelConfig {
protected getPanelConfig(): WebviewPanelConfig {
return {
viewId: 'remoteQueriesView',
title: 'CodeQL Query Results',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ViewColumn } from 'vscode';
import { AbstractWebview, InterfacePanelConfig } from '../abstract-webview';
import { AbstractWebview, WebviewPanelConfig } from '../abstract-webview';
import { WebviewMessage } from '../interface-utils';
import { logger } from '../logging';

Expand All @@ -8,7 +8,7 @@ export class VariantAnalysisView extends AbstractWebview<WebviewMessage, Webview
this.getPanel().reveal(undefined, true);
}

protected getPanelConfig(): InterfacePanelConfig {
protected getPanelConfig(): WebviewPanelConfig {
return {
viewId: 'variantAnalysisView',
title: 'CodeQL Query Results',
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/compare/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { WebviewDefinition } from '../webview-interface';
import { WebviewDefinition } from '../webview-definition';
import { Compare } from './Compare';

const definition: WebviewDefinition = {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/remote-queries/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { WebviewDefinition } from '../webview-interface';
import { WebviewDefinition } from '../webview-definition';
import { RemoteQueries } from './RemoteQueries';

const definition: WebviewDefinition = {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { WebviewDefinition } from '../webview-interface';
import { WebviewDefinition } from '../webview-definition';
import { ResultsApp } from './results';

const definition: WebviewDefinition = {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/variant-analysis/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { WebviewDefinition } from '../webview-interface';
import { WebviewDefinition } from '../webview-definition';
import { VariantAnalysis } from './VariantAnalysis';

const definition: WebviewDefinition = {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/webview.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as ReactDOM from 'react-dom';
import { vscode } from './vscode-api';

import { WebviewDefinition } from './webview-interface';
import { WebviewDefinition } from './webview-definition';

// Allow all views to use Codicons
import '@vscode/codicons/dist/codicon.css';
Expand Down