Renamed 'interface managers' to something more specific#1510
Merged
Conversation
koesie10
approved these changes
Sep 14, 2022
Member
koesie10
left a comment
There was a problem hiding this comment.
LGTM, although I'd prefer the WebviewBase to be named something like AbstractView just so it's the same pattern as the views. This is just a personal preference though, I'm also happy to go with WebviewBase.
| sandbox = sinon.createSandbox(); | ||
|
|
||
| localQueriesInterfaceManagerStub = { | ||
| localQueriesResutsViewStub = { |
Member
There was a problem hiding this comment.
Suggested change
| localQueriesResutsViewStub = { | |
| localQueriesResultsViewStub = { |
| } | ||
|
|
||
| export class InterfaceManager extends AbstractInterfaceManager<IntoResultsViewMsg, FromResultsViewMsg> { | ||
| export class ResultsView extends WebviewBase<IntoResultsViewMsg, FromResultsViewMsg> { |
Member
There was a problem hiding this comment.
Should this file be called view.ts rather than interface.ts?
Contributor
Author
There was a problem hiding this comment.
I was tempted to rename it but it has a bunch of other stuff in there so it didn't make sense to rename it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term "interface manager" is used to represent the interface between the core extension run time and a certain web view. The name seems a bit too vague to me so I've made some renames:
See individual commits for the exact renames.