Skip to content

First pass at using VS Code UI toolkit#1382

Merged
charisk merged 3 commits intomainfrom
charisk/webview-ui-toolkit
Jun 16, 2022
Merged

First pass at using VS Code UI toolkit#1382
charisk merged 3 commits intomainfrom
charisk/webview-ui-toolkit

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jun 15, 2022

Start using the VS Code Webview UI toolkit instead of Primer.

This change covers:

  • Using VSCodeBadge instead of our custom Badge component
  • Using VSCodeButton instead of our custom ActionButton
  • Using VSCodeLink instead of Primer's Link

More changes around migration of other components will happen in future PRs.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners June 15, 2022 07:43
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall—just a question/comment about the styling of links 🖼️ 📝

Comment thread extensions/ql-vscode/src/remote-queries/view/FileCodeSnippet.tsx
Comment thread extensions/ql-vscode/src/remote-queries/view/FileCodeSnippet.tsx
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out and everything looks good. I like how so few things need to change for this.

@charisk charisk enabled auto-merge (squash) June 16, 2022 08:15
@charisk charisk merged commit efcade8 into main Jun 16, 2022
@charisk charisk deleted the charisk/webview-ui-toolkit branch June 16, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants