Minor webview fixes#1217
Merged
shati-patel merged 2 commits intomainfrom Mar 17, 2022
Merged
Conversation
charisk
reviewed
Mar 17, 2022
| {message && severity && <Message | ||
| message={message} | ||
| currentLineNumber={startingLine + index} | ||
| currentLineNumber={startingLine + index - 1} |
Contributor
There was a problem hiding this comment.
As you say, this works, however I think it'll be more intuitive if we left this line of code as is and just moved the Message component below the Box component instead.
Contributor
Author
There was a problem hiding this comment.
That's far too sensible 😂
(done)
charisk
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puts the annotation for an alert below the highlighted line instead of above. (PS: I'm not sure if this is the right fix, but it looks good at least 🤷🏽)
(Also converts a space to
to stop an overenthusiastic linter from stripping it off the end of the line.)Checklist
ready-for-doc-reviewlabel there.