Skip to content

Remove use of all-results artifact #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charisk merged 1 commit into from
Feb 8, 2022
Merged

Remove use of all-results artifact #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions extensions/ql-vscode/src/remote-queries/gh-actions-api-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ export async function getRemoteQueryIndex(
const resultIndexArtifactId = getArtifactIDfromName('result-index', workflowUri, artifactList);
const resultIndexItems = await getResultIndexItems(credentials, owner, repoName, resultIndexArtifactId);

const allResultsArtifactId = getArtifactIDfromName('all-results', workflowUri, artifactList);

const items = resultIndexItems.map(item => {
const artifactId = getArtifactIDfromName(item.id, workflowUri, artifactList);

Expand All @@ -50,9 +48,8 @@ export async function getRemoteQueryIndex(
});

return {
allResultsArtifactId,
artifactsUrlPath,
items,
items
};
}

Expand Down
1 change: 0 additions & 1 deletion extensions/ql-vscode/src/remote-queries/remote-queries-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export class RemoteQueriesInterfaceManager {
totalResultCount: totalResultCount,
executionTimestamp: this.formatDate(query.executionStartTime),
executionDuration: executionDuration,
downloadLink: queryResult.allResultsDownloadLink,
analysisSummaries: analysisSummaries
};
}
Expand Down
6 changes: 1 addition & 5 deletions extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,7 @@ export class RemoteQueriesManager {

return {
executionEndTime,
analysisSummaries,
allResultsDownloadLink: {
id: resultIndex.allResultsArtifactId.toString(),
urlPath: `${resultIndex.artifactsUrlPath}/${resultIndex.allResultsArtifactId}`
}
analysisSummaries
};
}
}
1 change: 0 additions & 1 deletion extensions/ql-vscode/src/remote-queries/remote-query-result-index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export interface RemoteQueryResultIndex {
artifactsUrlPath: string;
allResultsArtifactId: number;
items: RemoteQueryResultIndexItem[];
}

Expand Down
1 change: 0 additions & 1 deletion extensions/ql-vscode/src/remote-queries/remote-query-result.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { DownloadLink } from './download-link';
export interface RemoteQueryResult {
executionEndTime: Date;
analysisSummaries: AnalysisSummary[];
allResultsDownloadLink: DownloadLink;
}

export interface AnalysisSummary {
Expand Down
4 changes: 0 additions & 4 deletions extensions/ql-vscode/src/remote-queries/sample-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ export const sampleRemoteQuery: RemoteQuery = {

export const sampleRemoteQueryResult: RemoteQueryResult = {
executionEndTime: new Date('2022-01-06T17:04:37.026Z'),
allResultsDownloadLink: {
id: '137697018',
urlPath: '/repos/big-corp/controller-repo/actions/artifacts/137697018'
},
analysisSummaries: [
{
nwo: 'big-corp/repo1',
Expand Down
1 change: 0 additions & 1 deletion extensions/ql-vscode/src/remote-queries/shared/remote-query-result.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export interface RemoteQueryResult {
totalResultCount: number;
executionTimestamp: string;
executionDuration: string;
downloadLink: DownloadLink;
analysisSummaries: AnalysisSummary[]
}

Expand Down
4 changes: 0 additions & 4 deletions extensions/ql-vscode/src/remote-queries/view/RemoteQueries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ const emptyQueryResult: RemoteQueryResult = {
totalResultCount: 0,
executionTimestamp: '',
executionDuration: '',
downloadLink: {
id: '',
urlPath: '',
},
analysisSummaries: []
};

Expand Down