Skip to content

Auto-download analyses results#1098

Merged
charisk merged 5 commits intomainfrom
charisk/auto-download-results
Jan 27, 2022
Merged

Auto-download analyses results#1098
charisk merged 5 commits intomainfrom
charisk/auto-download-results

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 25, 2022

Kick off auto-downloading of analyses results once a remote query has completed successfully.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner January 25, 2022 16:56
Comment thread extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts
Comment thread extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts Outdated
charisk and others added 2 commits January 26, 2022 09:27
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A handful of non-blocing, very minor suggestions.

Comment thread extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts Outdated
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
@charisk charisk enabled auto-merge (squash) January 27, 2022 08:43
@charisk charisk merged commit f8690bc into main Jan 27, 2022
@charisk charisk deleted the charisk/auto-download-results branch January 27, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants