Monitor remote query run and render results#1033
Merged
Conversation
51c7ecb to
41f712e
Compare
aeisenberg
reviewed
Dec 6, 2021
aeisenberg
reviewed
Dec 6, 2021
shati-patel
reviewed
Dec 7, 2021
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments 🌻
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
shati-patel
approved these changes
Dec 7, 2021
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks for the updates! Looks good from my point of view now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces logic to monitor the progress of a remote query as well as rendering the remote queries view using real data from the result of the query.
The notification that links to the Actions workflow is still in place:
But once the query is complete, you get one more notification (assuming you leave VS Code open):
Which leads to a view similar to the following:
Summary of changes
codeQL.monitorRemoteQuerycommand that is executed once the remote query has been submitted to run. The new command is not visible to the user.RemoteQueriesManagerthat is used as an entry point for running and monitoring remote queries from the extension. This class then uses theRemoteQuriesMonitorto monitor the progress of the query and theRemoteQueriesInterfaceManagerto prepare data for the view and render the view.Checklist
N/A: Still an internal-only feature. No user-visible changes.
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.