Make the telemetry acceptance dialog modal

Author: aeisenberg

extensions/ql-vscode/src/telemetry.ts

@@ -146,9 +146,14 @@ export class TelemetryListener extends ConfigListener {
         result = await Promise.race([
           showBinaryChoiceDialog(
             'Do we have your permission to collect anonymous usage statistics help us improve CodeQL for VSCode? See [TELEMETRY.md](https://github.com/github/vscode-codeql/blob/main/.github/TELEMETRY.md)',
-            false
+            // TODO: We make this dialog modal for now. If users complain, then we make it non-modal
+            // If we do decide to keep this dialog as modal, then this implementation can change and
+            // we no longer need to call Promise.race. Before committing this PR, we need to make
+            // this decision.
+            true
           ),
-          new Promise(resolve => setTimeout(resolve, 10000))
+          // Uncomment if we make the dialog non-modal
+          // new Promise(resolve => setTimeout(resolve, 10000))
         ]) as boolean | undefined;
       }
       if (result !== undefined) {