Do not send telemetry error events

Author: aeisenberg

extensions/ql-vscode/src/telemetry.ts

@@ -130,25 +130,6 @@ export class TelemetryListener extends ConfigListener {
       },
       { executionTime }
     );
-
-    // if this is a true error, also report it
-    if (status === CommandCompletion.Failed && error) {
-      const redactedError = {
-        name: error.name,
-        stack: error.stack,
-        message: '<MESSAGE REDACTED>'
-      };
-      this.reporter.sendTelemetryException(
-        redactedError,
-        {
-          type: 'command-usage',
-          name,
-          status,
-          isCanary
-        },
-        { executionTime }
-      );
-    }
   }
 
   /**

extensions/ql-vscode/src/vscode-tests/no-workspace/telemetry.test.ts

@@ -19,7 +19,6 @@ describe('telemetry reporting', function() {
   // setting preferences can trigger lots of background activity
   // so need to bump up the timeout of this test.
   this.timeout(10000);
-  this.timeout(1000000000);
 
   let originalTelemetryExtension: boolean | undefined;
   let originalTelemetryGlobal: boolean | undefined;
@@ -171,34 +170,6 @@ describe('telemetry reporting', function() {
     expect(TelemetryReporter.prototype.sendTelemetryException).not.to.have.been.called;
   });
 
-  it('should send a command usage event with a error', async () => {
-    await telemetryListener.initialize();
-    const err = new Error('my-error');
-
-    telemetryListener.sendCommandUsage('command-id', 1234, err);
-
-    expect(TelemetryReporter.prototype.sendTelemetryEvent).to.have.been.calledOnceWith('command-usage',
-      {
-        name: 'command-id',
-        status: 'Failed',
-        isCanary
-      },
-      { executionTime: 1234 });
-
-    expect(TelemetryReporter.prototype.sendTelemetryException).to.have.been.calledOnceWith({
-      name: err.name,
-      message: '<MESSAGE REDACTED>',
-      stack: err.stack
-    },
-      {
-        name: 'command-id',
-        status: 'Failed',
-        type: 'command-usage',
-        isCanary
-      },
-      { executionTime: 1234 });
-  });
-
   it('should send a command usage event with an error', async () => {
     await telemetryListener.initialize();