Skip to content

Year setter typo#242

Merged
jonrohan merged 2 commits intogithub:mainfrom
idlewan:year-setter-typo
Jan 12, 2023
Merged

Year setter typo#242
jonrohan merged 2 commits intogithub:mainfrom
idlewan:year-setter-typo

Conversation

@idlewan
Copy link
Copy Markdown
Contributor

@idlewan idlewan commented Jan 12, 2023

I've noticed that there's a typo in the year setter, preventing the ability to customize the format for the year (especially when using the datetime format) - it affects the day format instead.

One test (unrelated) also expected its output to omit the date because of the default behavior when the current year is the same as the date's year, so the second commit here addresses that failing test.

@idlewan idlewan requested a review from a team as a code owner January 12, 2023 13:04
@primer-css
Copy link
Copy Markdown

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

Copy link
Copy Markdown
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thanks!

@jonrohan jonrohan merged commit e46316c into github:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants