Conversation
b7f8e98 to
fc62cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#226 aimed to simplify the various relative durations we render. In doing so, we used a traditional half rounding method where if the value was over half way toward the next largest value then it'd be rounded up to the next largest value (e.g. 31 minutes became 1hr). Unfortunately this is a bit too generous for rounding dates, the loss becomes especially apparent when a date from 6 months ago says "last year".
This PR rectifies #226 by instead rounding at 90% (e.g. 55 minutes will be rounded to 1hr). This makes distant dates far more acceptable, for example a date 11 months ago will say "last year". This should "feel" more accurate when reading relative dates.