Add open-props topic#4660
Conversation
jmeridth
left a comment
There was a problem hiding this comment.
Couple requests. Thank you.
My change requests have been handled but still failures.
ahpook
left a comment
There was a problem hiding this comment.
Not sure where the copypasta is from but it should have attribution. Please link to the source of that text with a "(From : )" at the bottom.
Also you included headers from the original page which will not work in this context.
| **Overview** | ||
|
|
||
| [//youtube-embed-unfurl//]: # (hW-itQMKyiU) | ||
|
|
||
| **Watch it in action** | ||
|
|
||
| [//youtube-embed-unfurl//]: # (9VXR_qRgROE) No newline at end of file |
There was a problem hiding this comment.
| **Overview** | |
| [//youtube-embed-unfurl//]: # (hW-itQMKyiU) | |
| **Watch it in action** | |
| [//youtube-embed-unfurl//]: # (9VXR_qRgROE) |
These headers and links are copy-pasted from somewhere else and will not work.
There was a problem hiding this comment.
Is there something else I might change? What do you mean about the copypasta? The thing about the youtube embeds? I took it from another topic (original answer), I thought it was an undocumented feature but I'm ok removing those. If you mean the text I redacted it myself. Please let me know if any more changes are needed or if I have to make a new pull request, I just accepted the changes provided by Eric.
lgtm Co-authored-by: Eric Sorenson <ahpook@github.com> Signed-off-by: srgeneroso <5541794+SrGeneroso@users.noreply.github.com>
ahpook
left a comment
There was a problem hiding this comment.
LGTM, nice curation, thank you @SrGeneroso !
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsOpen Props is a very thoughtful and comprehensive design tool that manages to be easy to use, beautiful and fully compatible with any project that uses CSS. It was made by Adam Argyle, who is one of the best advocates for CSS (He is currently working on google for the CSS group for chrome). Please consider this entry as it is the best way I can find to show some love to the project and the awesome community around it.
Something that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.