Skip to content

Add open-props topic#4660

Merged
ahpook merged 5 commits intogithub:mainfrom
SrGeneroso:create-topic
Apr 18, 2025
Merged

Add open-props topic#4660
ahpook merged 5 commits intogithub:mainfrom
SrGeneroso:create-topic

Conversation

@SrGeneroso
Copy link
Copy Markdown
Contributor

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Open Props is a very thoughtful and comprehensive design tool that manages to be easy to use, beautiful and fully compatible with any project that uses CSS. It was made by Adam Argyle, who is one of the best advocates for CSS (He is currently working on google for the CSS group for chrome). Please consider this entry as it is the best way I can find to show some love to the project and the awesome community around it.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@SrGeneroso SrGeneroso requested a review from a team as a code owner March 6, 2025 19:00
Copy link
Copy Markdown
Contributor

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple requests. Thank you.

Comment thread topics/open-props/index.md Outdated
Comment thread topics/open-props/index.md Outdated
@SrGeneroso SrGeneroso requested a review from jmeridth March 15, 2025 17:54
Comment thread topics/open-props/index.md Outdated
@SrGeneroso SrGeneroso requested a review from jmeridth March 21, 2025 00:02
@jmeridth jmeridth dismissed their stale review March 25, 2025 12:08

My change requests have been handled but still failures.

Copy link
Copy Markdown
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where the copypasta is from but it should have attribution. Please link to the source of that text with a "(From : )" at the bottom.

Also you included headers from the original page which will not work in this context.

Comment thread topics/open-props/index.md Outdated
Comment on lines +19 to +25
**Overview**

[//youtube-embed-unfurl//]: # (hW-itQMKyiU)

**Watch it in action**

[//youtube-embed-unfurl//]: # (9VXR_qRgROE) No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Overview**
[//youtube-embed-unfurl//]: # (hW-itQMKyiU)
**Watch it in action**
[//youtube-embed-unfurl//]: # (9VXR_qRgROE)

These headers and links are copy-pasted from somewhere else and will not work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something else I might change? What do you mean about the copypasta? The thing about the youtube embeds? I took it from another topic (original answer), I thought it was an undocumented feature but I'm ok removing those. If you mean the text I redacted it myself. Please let me know if any more changes are needed or if I have to make a new pull request, I just accepted the changes provided by Eric.

lgtm

Co-authored-by: Eric Sorenson <ahpook@github.com>
Signed-off-by: srgeneroso <5541794+SrGeneroso@users.noreply.github.com>
@SrGeneroso SrGeneroso requested a review from ahpook March 30, 2025 14:36
@SrGeneroso
Copy link
Copy Markdown
Contributor Author

SrGeneroso commented Apr 15, 2025

@jmeridth Hi, this topic got cold. Is anything I need to fix or with the changes proposed by @ahpook is finally shippable? Let me know

Copy link
Copy Markdown
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice curation, thank you @SrGeneroso !

@ahpook ahpook merged commit 1e1057d into github:main Apr 18, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants