Add rule to prohibit building script tags in the client#223
Merged
manuelpuyol merged 3 commits intomainfrom Mar 25, 2022
Merged
Add rule to prohibit building script tags in the client#223manuelpuyol merged 3 commits intomainfrom
manuelpuyol merged 3 commits intomainfrom
Conversation
theinterned
reviewed
Mar 24, 2022
theinterned
reviewed
Mar 24, 2022
theinterned
approved these changes
Mar 24, 2022
Contributor
theinterned
left a comment
There was a problem hiding this comment.
❤️ Thank you for addressing my feedback!
koddsson
reviewed
Mar 25, 2022
| ] | ||
| }, | ||
| { | ||
| code: 'document.createElement("span").type = "text/javascript"', |
Contributor
There was a problem hiding this comment.
This should be a script right? Spans don't have a type.
Contributor
Author
There was a problem hiding this comment.
I just wanted to test that .type = "text/javascript" will fail. If I add document.createElement("script"), it will fail without checking the type
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should never allow building
scripttags in our applications since they side-step some security measures.