chore: Minor typo cleanup#166
Merged
srt32 merged 1 commit intogithub:mainfrom Dec 8, 2021
Merged
Conversation
srt32
reviewed
Dec 8, 2021
| }, | ||
| { | ||
| // Intentionally mispelled! | ||
| // Intentionally misspelled! |
Contributor
Author
There was a problem hiding this comment.
Yeah, I didn't correct the intentional typo below :)
| If `polishApple` needed to do some serial async work, then we'd need to refactor the iteration steps to accommodate for this async work, by `await`ing each call to `polishApple`. We cannot simply pass an `async` function to `forEach`, as it does not understand async functions, instead we'd have to turn the `forEach` into a `reduce` and combine that with a `Promise` returning function. For example: | ||
|
|
||
| ```diff | ||
| - apples.forEach(polishApple) |
Contributor
Author
There was a problem hiding this comment.
The line you're commenting on is a code block with diff language tag, not something I changed
srt32
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took a quick pass with cSpell