Packaging: Refactor java and C##6514
Merged
aeisenberg merged 3 commits intomainfrom Aug 20, 2021
Merged
Conversation
cb527e2 to
edd658f
Compare
Contributor
Author
|
Could someone explain why the qldocs are failing? It looks like neither the baseline nor this PR has those items documented. |
edd658f to
11f3c6a
Compare
hvitved
reviewed
Aug 19, 2021
Contributor
hvitved
left a comment
There was a problem hiding this comment.
I have really no idea how to review this PR, but I do note that none of the contents in the C# .qll files change, which is good.
11f3c6a to
8245427
Compare
576a877 to
42b34ee
Compare
Split java pack into `codeql/java-all` and `codeql/java-queries`.
Split c# pack into `codeql/csharp-all` and `codeql/csharp-queries`.
42b34ee to
c9f1c98
Compare
adityasharad
approved these changes
Aug 19, 2021
Collaborator
|
Planning to ignore the QLDoc Checks, since they are confused by the files being moved. Will merge once the Java and C# tests both pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors two languages at the same time, similar to how C++ was done.