Skip to content

C++: Fix false-positive in 'cpp/incorrect-allocation-error-handling' #6471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 3 commits into from
Aug 11, 2021
Merged

C++: Fix false-positive in 'cpp/incorrect-allocation-error-handling' #6471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b1da0
C++: Add FP testcase with an 'new' that has a 'std::nothrow&' paramet…
MathiasVP Aug 11, 2021
0d1884d
C++: Fix FP and accept test changes.
MathiasVP Aug 11, 2021
8d594db
Update cpp/ql/test/query-tests/Security/CWE/CWE-570/test.cpp
MathiasVP Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/ql/src/Security/CWE/CWE-570/IncorrectAllocationErrorHandling.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class ThrowingAllocator extends Function {
// 3. the allocator isn't marked with `throw()` or `noexcept`.
not exists(this.getBlock()) and
not exists(Parameter p | p = this.getAParameter() |
p.getUnspecifiedType() instanceof NoThrowType
p.getUnspecifiedType().stripType() instanceof NoThrowType
) and
not this.isNoExcept() and
not this.isNoThrow()
Expand Down
10 changes: 9 additions & 1 deletion cpp/ql/test/query-tests/Security/CWE/CWE-570/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,12 @@ void good_new_catch_exception_in_conversion() {
try {
long* p = (long*) new int; // GOOD
} catch(const std::bad_alloc&) { }
}
}

// The 'n' parameter is just to distinquish it from the overload further up in this file.
void *operator new(std::size_t, int n, const std::nothrow_t &);

void test_operator_new_without_exception_spec() {
int* p = new(42, std::nothrow) int; // GOOD
if(p == nullptr) {}
}