JS: fix cfg and dataflow for logical compound assignments#6459
Merged
codeql-ci merged 1 commit intogithub:mainfrom Aug 11, 2021
Merged
JS: fix cfg and dataflow for logical compound assignments#6459codeql-ci merged 1 commit intogithub:mainfrom
codeql-ci merged 1 commit intogithub:mainfrom
Conversation
asgerf
approved these changes
Aug 11, 2021
Contributor
asgerf
left a comment
There was a problem hiding this comment.
👍
I'm somewhat unsure about the change in the data-flow graph.
For &&= it will likely cause the same issue we're seeing with && but since we already have that problem with && it's not something that needs to be fixed in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6362
An evaluation looks fine.
The result difference gains TPs and removes FPs.
The change in
CFGExtractor.javacorrected an edge in the CFG.For an assignment
foo ||= barthere was an edge frombartofoo, which was incorrect.It has been corrected to be an edge from
bartofoo ||= bar.And I've added data-flow edges from both the
lhsandrhsto the assignment itself.I'm somewhat unsure about the change in the data-flow graph.