Skip to content

C#: Two pragma performance fixes #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 3 commits into from
Jul 17, 2021
Merged

C#: Two pragma performance fixes #6303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e4d761
C#: Add `nomagic` to `NamedElement::getQualifiedName()`
hvitved Jul 15, 2021
4180528
C#: Do not inline `getLeafTypeAt`
hvitved Jul 15, 2021
45ee216
C#: Cache `NamedElement::getQualifiedName()`
hvitved Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csharp/ql/src/semmle/code/csharp/Unification.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ module Gvn {
/**
* Gets the leaf GVN inside GVN `t`, by following the path `path`, if any.
*/
pragma[noinline]
private GvnType getLeafTypeAt(GvnType t, TTypePath path) {
result = getTypeAt(t, path) and
not result instanceof ConstructedGvnType
Expand Down
1 change: 1 addition & 0 deletions csharp/ql/src/semmle/code/dotnet/Element.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class NamedElement extends Element, @dotnet_named_element {
* }
* ```
*/
cached
final string getQualifiedName() {
exists(string qualifier, string name | this.hasQualifiedName(qualifier, name) |
if qualifier = "" then result = name else result = qualifier + "." + name
Expand Down