Ensure only one query per language is tagged lines-of-code#6163
Merged
criemen merged 1 commit intogithub:mainfrom Jun 28, 2021
Merged
Ensure only one query per language is tagged lines-of-code#6163criemen merged 1 commit intogithub:mainfrom
lines-of-code#6163criemen merged 1 commit intogithub:mainfrom
Conversation
Some languages have multiple `summary` queries for lines of code, representing different forms of counting (user written, total, etc). When Code Scanning sees results from multiple such summary queries in a single run, it will need to choose one as the primary LoC count to display in the UI. By ensuring only one query per language has the `lines-of-code` tag, in future we can teach Code Scanning to look for this particular tag to identify the primary LoC count. If a "lines of user code" query is available, use that. Otherwise use the total "lines of code". (It is completely fine for multiple queries to be tagged with `summary`.)
esbena
approved these changes
Jun 26, 2021
Contributor
|
Might be nice to mention |
Contributor
|
👍 #6257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some languages have multiple
summaryqueries for lines of code, representing different forms of counting (user written, total, etc). When Code Scanning sees results from multiple such summary queries in a single run, it will need to choose one as the primary LoC count to display in the UI.By ensuring only one query per language has the
lines-of-codetag, in future we can teach Code Scanning to look for this particular tag to identify the primary LoC count.If a "lines of user code" query is available, use that.
Otherwise use the total "lines of code".
(It is completely fine for multiple queries to be tagged with
summary, and for there to be multiple forms of LoC query.)