Java: Ignore char array based closeables for CloseReader.ql and CloseWriter.ql#5868
Conversation
3d1969f to
8969da7
Compare
|
Should note in the PR and/or a commit message: guessing you removed |
|
Ah, sorry I have mentioned it in #5868 (comment), but have already resolved that. If you want I can split the removal into a separate commit, or edit the commit message. Which one do you prefer? |
|
The safe option would be to leave it alone, if we're unsure what it was supposed to do. |
|
This still needs a change-note. lgtm,codescanning
* The 'Potential input resource leak' (java/input-resource-leak) and
'Potential output resource leak' (java/output-resource-leak) queries have been improved to produce fewer false positives. |
Added it back, but left a comment to explain why an unqualified name is used.
Thanks! I have used a slightly different wording, but I hope it is fine nonetheless. |
smowton
left a comment
There was a problem hiding this comment.
Over to @aschackmull for final review
|
Oops, indeed US spelling is standard for this codebase |
Adds
CharArrayReaderandCharArrayWriteras safe closeables to reduce false positives.