JS: recognize more library input#5826
Merged
codeql-ci merged 5 commits intogithub:mainfrom May 5, 2021
Merged
Conversation
esbena
reviewed
May 5, 2021
Contributor
esbena
left a comment
There was a problem hiding this comment.
I think https://github.com/github/codeql/pull/5826/files#diff-f8a3dfa03038e23405f8fc8c6002982fdf9f4c38a65c10ed68a12e8005a5db7cR21 has become a bit outdated now Maybe the line should just be deleted.
Seeing how big and heuristic the disjunction in getAValueExportedByPackage has become, I would like to see source code examples for each disjunct. If not in this PR, then a follow-up PR.
| // .... | ||
| // })); | ||
| // ``` | ||
| exists(ImmediatelyInvokedFunctionExpr func, DataFlow::ParameterNode prev, int i | |
Contributor
There was a problem hiding this comment.
Could this be related to the define.amd check? I think name-matching on "factory" is a bit too heuristic.
Contributor
Author
There was a problem hiding this comment.
I've related it to the define(..) call.
I also missed a check that the file was actually exported 😬
That is added now.
esbena
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognizes a library-input source for CVE-2017-0931 and CVE-2017-1001004.
Evaluation looks good.
No change in performance, and a few new poly-redos TPs.