C++: Change countNumberOfBranchesUsingParameter to match qldoc closer.#18908
Merged
MathiasVP merged 1 commit intogithub:mainfrom Mar 5, 2025
Merged
Conversation
Contributor
Author
|
Dca looks fine, so opening this for review. @MathiasVP looks like there was an issue with QA - do you want to retry that or is the dca run sufficient? |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Contributor
|
Ì think we should redo QA. I'll restart it now |
Contributor
Author
|
QA looks sufficiently uneventful, I think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes one ad-hoc fieldFlowBranchLimit tweak to another. I tried to do some comparisons on the computed counts, and there are plenty of discrepancies, but that's possibly completely fine - let's see what dca says.
The primary motivation for this change is to get rid of the dependence on SSA Phi Read nodes, which I plan to hide within the SSA library.