Skip to content

C#: Deprecate UnboundGenericType::getInstanceType/0#14688

Merged
hvitved merged 1 commit intogithub:mainfrom
hvitved:csharp/deprecate-get-instance-type
Nov 6, 2023
Merged

C#: Deprecate UnboundGenericType::getInstanceType/0#14688
hvitved merged 1 commit intogithub:mainfrom
hvitved:csharp/deprecate-get-instance-type

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Nov 6, 2023

This predicate would never contain any tuples, given that the extractor considers a constructed type C<T1, ..., Tn>, where Ti is the ith type parameter of C, identical with the unbound generic type C`n.

@github-actions github-actions Bot added the C# label Nov 6, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 6, 2023
@hvitved hvitved marked this pull request as ready for review November 6, 2023 10:16
@hvitved hvitved requested a review from a team as a code owner November 6, 2023 10:16
* arguments being the corresponding type parameter.
*/
ConstructedType getInstanceType() {
deprecated ConstructedType getInstanceType() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a deprecation message?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hvitved hvitved force-pushed the csharp/deprecate-get-instance-type branch from fc81f3c to 12cd1c1 Compare November 6, 2023 12:02
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hvitved hvitved merged commit 4b9430d into github:main Nov 6, 2023
@hvitved hvitved deleted the csharp/deprecate-get-instance-type branch November 6, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants