Swift: Correct a couple of FilePath models.#14682
Merged
MathiasVP merged 3 commits intogithub:mainfrom Nov 6, 2023
Merged
Conversation
MathiasVP
reviewed
Nov 6, 2023
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
Would it be possible to ... add a test that shows the difference?
Contributor
Author
Will do. Note that I don't in general write tests for every single MAD source or sink - particularly when there are many similar ones, I feel that testing one of a set of near identical rows is often sufficient. |
Contributor
Good point. I just think it would be valuable as a justification for why this rewrite was necessary. |
…or return values from the closures.
Contributor
Author
|
Tests added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very minor fixes for the
FilePathmodel.The existing tests for this are unaffected.