Python: filter local self loops#14644
Merged
yoff merged 3 commits intogithub:mainfrom Nov 3, 2023
Merged
Conversation
04bd447 to
7704385
Compare
RasmusWL
reviewed
Nov 1, 2023
Factor out use-use flow in order to do this. Also improve names and comments. I also wanted to change the types in `difinitionFlowStep`, but that broke the module instantiation.
…ate.qll Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
219a811 to
fd757b0
Compare
yoff
commented
Nov 2, 2023
Comment on lines
+341
to
+342
| nodeFrom.(CfgNode).getNode() = pd.getDefiningNode() and | ||
| nodeTo.(EssaNode).getVar() = pd.getVariable() |
Contributor
Author
There was a problem hiding this comment.
These are rewritten to look like the others, with the hope that some day we can drop these casts, declaring the types in the predicate signature. At the moment, this breaks the module instantiation in localFlowStep below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should be filtered on use-use steps, so I have factored those out.
(If self loops appear on the other steps, we want the inconsistency check to tell us.)
Based on #14617 so should be rebased once that is merged.