Swift: add VarDecl children to CaptureListExpr#14633
Merged
Conversation
geoffw0
reviewed
Oct 30, 2023
| @@ -1,2 +1,4 @@ | |||
| testFailures | |||
| | closures.swift:180:16:181:1 | // $ hasValueFlow=captureThis\n | Missing result:hasValueFlow=captureThis | | |||
| | closures.swift:181:21:182:1 | // $ hasValueFlow=captureThis\n | Missing result:hasValueFlow=captureThis | | |||
Contributor
There was a problem hiding this comment.
If you update the inline expectations labels on lines 180 and 181 of the test (delete MISSING and add =captureThis) we won't get these two reported testFailures.
geoffw0
reviewed
Oct 31, 2023
| variables: list[VarDecl] | child | ||
| variables: list[VarDecl] | child | synth | desc(""" | ||
| These are the variables introduced by this capture in the closure's scope, not the captured ones. | ||
| """) |
Contributor
There was a problem hiding this comment.
This is a helpful distinction to clarify. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can actually be done fully in QL with a synthesized child property, as the variables can be retrieved from the
BindingDecls.Closes https://github.com/github/codeql-c-team/issues/2016