Skip to content

Swift: implement type pruning for dataflow #14592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdmarsh2 wants to merge 21 commits into from
Closed

Swift: implement type pruning for dataflow #14592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6e3f79b
Swift: WIP dataflow type pruning
Oct 6, 2023
4da8727
Swift: Type pruning WIP
Oct 20, 2023
f0528cd
Swift: add getType to DataFlow::Node
Oct 23, 2023
68d0ca7
Swift: fix Function.getResultType for generics
Oct 25, 2023
e6eaf97
Swift: fix parameter types in dataflow pruning
Oct 25, 2023
6d85063
Undo accidental removal of cached annotations
Oct 26, 2023
bc68e3f
Swift: model function types with a "top" type for performance
Nov 6, 2023
9a92b68
Swift: introduce `getDataFlowType`
Nov 6, 2023
ae0aebc
Swift: account for generic types in type pruning
Nov 8, 2023
7a4cfca
Swift: fix dictionary iterator flow with type pruning
Nov 15, 2023
e45a33e
Swift: docs for `AnyType`
Nov 20, 2023
376a57a
Swift: strip labels from tuples in type pruning
Nov 28, 2023
a39fb48
Swift: fix a join order issue in compatibleTypes
Nov 29, 2023
23866c5
Swift: uncomment accidentally commented-out lines
Nov 29, 2023
5b4152a
Swift: autoformat
Nov 29, 2023
eb55e97
Swift: try to improve performance in compatibleTypes
Dec 11, 2023
62cd974
Swift: more CompatibleTypes performance improvements
Dec 11, 2023
1ee6a03
Swift: Fix type pruning performance.
geoffw0 Dec 11, 2023
35573d2
Merge branch 'main' into rdmarsh2/swift/dataflow-type-pruning
Dec 22, 2023
9c2bb77
Swift: fix missing type for keypath entry nodes
Dec 22, 2023
663c6ce
Swift: switch to using preupdate node types for postupdate nodes
Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions swift/ql/lib/codeql/swift/dataflow/Ssa.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ module Ssa {

EntryNode asKeyPath() { none() }

abstract Type getType();

DeclRefExpr getAnAccess() { result.getDecl() = this.asVarDecl() }

Location getLocation() {
Expand All @@ -48,6 +50,10 @@ module Ssa {

override string toString() { result = v.toString() }

override Type getType() {
result = v.getType()
}

override VarDecl asVarDecl() { result = v }
}

Expand All @@ -56,6 +62,10 @@ module Ssa {

KeyPathSourceVariable() { this = TKeyPathSourceVariable(enter) }

override Type getType() {
result = enter.getScope().(KeyPathExpr).getRoot().getType()
}

override string toString() { result = enter.toString() }

override EntryNode asKeyPath() { result = enter }
Expand Down
Loading