C++: Fix strtok model for indirections#14587
Merged
MathiasVP merged 2 commits intogithub:mainfrom Oct 25, 2023
Merged
Conversation
jketema
approved these changes
Oct 25, 2023
Contributor
jketema
left a comment
There was a problem hiding this comment.
LGTM. Do we need DCA for this?
Contributor
Author
|
Oh yeah. I'll start one now. |
Contributor
Author
|
The integration test failures looks unrelated (they're all in Java-related tests). |
Contributor
Author
|
DCA shows the expected new results 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a missing case for the
strtokmodel. The problem was revealed by the fixes in #14571, but the DCA run for the project that had this regression failed the DCA run. So we didn't spot the regression in the PR 😭.