Skip to content

C++: Remove unnecessary FlowState from cpp/overrun-write#14486

Merged
MathiasVP merged 1 commit intogithub:mainfrom
MathiasVP:simplify-overrun-write
Oct 12, 2023
Merged

C++: Remove unnecessary FlowState from cpp/overrun-write#14486
MathiasVP merged 1 commit intogithub:mainfrom
MathiasVP:simplify-overrun-write

Conversation

@MathiasVP
Copy link
Copy Markdown
Contributor

This flow state was necessary to have a PathNode for every place where pointer arithmetic was performed (because a state change always breaks up the big-step relation). However, in #13717 a change was made so that every additional flow step by default would break the big-step relation.

This means we don't need to have the hacky FlowState anymore 🎉

@MathiasVP MathiasVP requested a review from a team as a code owner October 12, 2023 13:00
@github-actions github-actions Bot added the C++ label Oct 12, 2023
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Oct 12, 2023
Copy link
Copy Markdown
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathiasVP MathiasVP merged commit 3c34638 into github:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants